Fix focus loop when autocompleting text on iOS #19234
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aztec can send us selection change events after it has lost focus.
For instance the autocorrect feature will complete a partially written word when resigning focus, causing a selection change event. Forwarding this selection change could cause this RichText to regain focus and start a focus loop.
This PR prevents that selection forwarding when the RichText component isn't already selected.
I'm not sure what other side effects this could have, so pinging several people on this one 😬
Fixes: wordpress-mobile/gutenberg-mobile#1696
How has this been tested?
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1698
Tested with the steps in wordpress-mobile/gutenberg-mobile#1696:
Checklist: